chore: relax RelatedAsset validation and filter invalid assets#8920
Merged
Conversation
joaosantos15
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes a production bug where one relatedAsset missing
sourceAssetIdcaused the entire What's Happening section to show an error state.nameandsourceAssetIdoptional inRelatedAssetStructand
RelatedAssettype (symbolis now the only required field)normalizeRelatedAssetswithfilterAndNormalizeRelatedAssetswhich strips assets with empty
symboland drops trends with zerovalid assets after filtering
References
Checklist
Note
Medium Risk
Changes public types and validation for market-overview related assets; clients must handle optional name/sourceAssetId, but behavior aligns with live API and reduces full-section failures.
Overview
Relaxes market overview
RelatedAssetvalidation so partially enriched API rows no longer fail the whole response.RelatedAsset.nameandRelatedAsset.sourceAssetIdare now optional in the superstruct schema (RelatedAssetStruct) and the exportedRelatedAssettype;symbolremains required. MissingnameorsourceAssetIdno longer causesfetchMarketOverviewto throwAPI_INVALID_RESPONSE. JSDoc now tells clients to fall back tosymbolwhennameis absent.Tests were updated: invalid-entry cases focus on a missing
symbol, and new cases assert successful overviews whensourceAssetIdornameis omitted. The changelog documents the fix under Unreleased → Fixed.Reviewed by Cursor Bugbot for commit 82c7647. Bugbot is set up for automated code reviews on this repo. Configure here.